git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/8] rebase: prepare to do generic housekeeping

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
May 10, 2013, 16:39 UTC
Message-ID
<CALkWK0=hK4Nj24xEYtfnAmrLsKLz+iJXvM4PKL9NHEJDS35mfQ@mail.gmail.com>
In-Reply-To
<7vvc6q3l6t.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> So it is either (1) the added code is unreachable and unexercised at
> this point in the series, or
Yeah, it's (1).
> Perhaps this should come a bit later in the series?

When exactly? I picked up on your suggestion to separate out the preparation-for-$backend-to-return step. The next three patches convert each of the $backend scripts to return.

> At least the log message should mention that this is adding an
> unreachable cruft at this step, if the order is to be kept.
Okay, I can update the commit message.
Previous: Junio C HamanoNext: Ramkumar Ramachandra
Message 12 of 18 in “rebase.autostash completed”
  1. 0/8 rebase.autostash completedRamkumar Ramachandra, May 10, 2013
  2. 1/8 am: suppress error output from a conditionalRamkumar Ramachandra, May 10, 2013
  3. Junio C HamanoMay 10, 2013
  4. Ramkumar RamachandraMay 11, 2013
  5. Junio C HamanoMay 12, 2013
  6. 2/8 rebase -i: don't error out if $state_dir already existsRamkumar Ramachandra, May 10, 2013
  7. 3/8 am: tighten a conditional that checks for $dotestRamkumar Ramachandra, May 10, 2013
  8. 4/8 rebase: prepare to do generic housekeepingRamkumar Ramachandra, May 10, 2013
  9. Eric SunshineMay 10, 2013
  10. Junio C HamanoMay 10, 2013
  11. Junio C HamanoMay 10, 2013
  12. Ramkumar RamachandraMay 10, 2013
  13. 5/8 am: return control to caller, for housekeepingRamkumar Ramachandra, May 10, 2013
  14. 6/8 rebase -i: return control to caller, for housekeepingRamkumar Ramachandra, May 10, 2013
  15. 7/8 rebase --merge: return control to caller, for housekeepingRamkumar Ramachandra, May 10, 2013
  16. 8/8 rebase: implement --[no-]autostash and rebase.autostashRamkumar Ramachandra, May 10, 2013
  17. Eric SunshineMay 10, 2013
  18. Junio C HamanoMay 10, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.