[PATCH 4/8] rebase: prepare to do generic housekeeping
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- May 10, 2013, 14:26 UTC
- Message-ID
- <1368196005-5354-5-git-send-email-artagnon@gmail.com>
- In-Reply-To
- <1368196005-5354-1-git-send-email-artagnon@gmail.com>
On successful completion of a rebase in git-rebase--$backend.sh, the $backend script cleans up on its own and exits. The cleanup routine is however, independent of the $backend, and each $backend script unnecessarily duplicates this work:
rm -rf "$state_dir"
git gc --autoPrepare git-rebase.sh for later patches that return control from each $backend script back to us, for performing this generic cleanup routine.
Another advantage is that git-rebase.sh can implement a generic finish_rebase() to possibly do additional tasks in addition to the cleanup.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> --- git-rebase.sh | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/git-rebase.sh b/git-rebase.sh index 2c692c3..84dc7b0 100755 --- a/git-rebase.sh +++ b/git-rebase.sh @@ -150,6 +150,13 @@ run_specific_rebase () { autosquash= fi . git-rebase--$type + ret=$? + if test $ret = 0 + then + git gc --auto && + rm -rf "$state_dir" + fi + exit $ret } run_pre_rebase_hook () {
-- 1.8.3.rc1.52.gc14258d