Re: [PATCH] t/test-lib: print pretty msg when git isn't built

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Sep 18, 2012, 08:07 UTC
Message-ID: <CALkWK0=JY3pTyyMAmFVnQatn6gd3eC7dxiBbTh0WmVwkdLTbHQ@mail.gmail.com>
In-Reply-To: <7vr4pzoj5a.fsf@alter.siamese.dyndns.org>

Hi Junio,

Junio C Hamano wrote:

Show 24 quoted lines

>> Junio C Hamano wrote:
>>> Yeah, but why change it so much?  Wouldn't writing
>>>
>>>         "$GIT_BUILD_DIR/git" >/dev/null
>>>         if test $? != 1
>>>         then
>>>                 : You haven't built git!
>>>         fi
>>>
>>> just like the original in 0000 be sufficient??
>>
>> Because that emits an ugly
>> ./test-lib.sh: 54: /home/artagnon/src/git/t/../git: not found
>
> Don't you deserve it? ;-)
>
> The full message would read
>
>     ./test-lib.sh: 54: /home/artagnon/src/git/t/../git: not found
>     error: you do not seem to have built git yet.
>
> which looks perfectly sensible to me.  It makes it clear where on
> the filesystem the test script expects your "git", which is an added
> benefit.

Fair enough- use your version then. Let me know if you want me to submit a revised patch.

Ram