Re: [PATCH] t/test-lib: print pretty msg when git isn't built

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 18, 2012, 08:00 UTC
Message-ID: <7vr4pzoj5a.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CALkWK0kbeLtU-5_9QnmQKS1yO02SvCW3ERvami9bmCa0Vym8oQ@mail.gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

Show 26 quoted lines

> Hi,
>
> Junio C Hamano wrote:
>> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>>
>>> Hi Junio,
>>>
>>> Junio C Hamano wrote:
>>>> Is this a sufficient replacement for what you removed from 0000?
>>>> Can the BUILD-OPTIONS file exist when your build of git failed?
>>>
>>> Oops, I didn't realize that BUILD-OPTIONS would be written when the
>>> build fails.  How about something like this instead:
>>
>> Yeah, but why change it so much?  Wouldn't writing
>>
>>         "$GIT_BUILD_DIR/git" >/dev/null
>>         if test $? != 1
>>         then
>>                 : You haven't built git!
>>         fi
>>
>> just like the original in 0000 be sufficient??
>
> Because that emits an ugly
> ./test-lib.sh: 54: /home/artagnon/src/git/t/../git: not found

Don't you deserve it? ;-)

The full message would read

    ./test-lib.sh: 54: /home/artagnon/src/git/t/../git: not found
    error: you do not seem to have built git yet.

which looks perfectly sensible to me. It makes it clear where on the filesystem the test script expects your "git", which is an added benefit.