Re: [PATCH 10/18] revert: Save data for continuing after conflict resolution
Hi again,
Jonathan Nieder writes:
Show 6 quoted lines
> Ramkumar Ramachandra wrote:
>> That these two files alone are not enough to implement a "--continue"
>> that remembers the command-line options specified; later patches in
>> the series save them too.
>
> Micronit: I think this sentence has an extra "That".
Show 8 quoted lines
>> +pristine_detach () {
>> + git checkout -f "$1^0" &&
>> + git read-tree -u --reset HEAD &&
>> + git clean -d -f -f -q -x
>> +}
>
> Nit: probably best to include the "rm -rf .git/sequencer" in this
> function. But I don't think that should hold up the patch.Ah, good idea. Fixed.
Thanks.
-- Ram