Re: [PATCH 01/16] t/t5505-remote: modernize subshell-style of one test
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Jun 22, 2013, 06:24 UTC
- Message-ID
- <CALkWK0=F1=8HyeJ=v=nUuHBAm0me6rdC0U+KYP4fXmhELV6xhQ@mail.gmail.com>
- In-Reply-To
- <7vehbvktmz.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
Show 5 quoted lines
> Good, but a "style only" patch like this should consider taking > advantage of the occasion to clean up the entire file, as we do not > often get enough chance to do so without conflicting with in-flight > topics. Is there something else that would conflict if this step > did so?
No, but the problem is that the file contains mixed-style which prevents me from automating my work with regular-expressions and macros easily. I have to break it up into regions and operate regexps/macros on specific regions, multiplying the number of errors I can possibly commit. Nevertheless, I'll do it: I don't want this to be a maintenance burden for us.