Re: Subject: [PATCH] config: mark a file-local symbol as static
- From
Sahil Dua <sahildua2305@gmail.com>
- Date
- Jun 17, 2017, 22:00 UTC
- Message-ID
- <CALiud+moeCUV5HibQDK9+cgMUWBQfrAGZ6i0Jcs1SNMjzXkkiQ@mail.gmail.com>
- In-Reply-To
- <CALiud+nZj4f1=puzXC6grfStg-tQLMGpr-dAdtNwphyvts5KmA@mail.gmail.com>
On Sat, Jun 17, 2017 at 11:40 PM, Sahil Dua <sahildua2305@gmail.com> wrote:
Show 6 quoted lines
> Hi Ramsay, > > Thanks for noticing. I will squash this into the relevant patch. > > Also, git_config_copy_section_in_file() and refs_copy_existing_ref() > don't need to be available in public API.
I noticed that git_config_copy_section_in_file() is declared in cache.h already. I made it this way to keep it consistent with existing git_config_rename_section_in_file().
Similarly with refs_copy_existing_ref(), it's similar to refs_rename_ref() (both of these are declared in refs.h).
Show 43 quoted lines
>
>
> On Thu, Jun 15, 2017 at 3:20 AM, Ramsay Jones
> <ramsay@ramsayjones.plus.com> wrote:
>>
>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
>> ---
>>
>> Hi Sahil,
>>
>> If you need to re-roll your 'sd/branch-copy' branch, could you please
>> squash this into the relevant patch (commit 37af9c71b6, "config: create
>> a function to format section headers", 13-06-2017).
>>
>> Also, I note that another patch in that branch (commit fd44da469c,
>> "branch: add a --copy (-c) option to go with --move (-m)", 13-06-2017),
>> adds a couple of external symbols which, currently, don't need to be
>> externally visible. Is it intended that git_config_copy_section_in_file()
>> and refs_copy_existing_ref() be part of the public API?
>>
>> Thanks!
>>
>> ATB,
>> Ramsay Jones
>>
>> config.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/config.c b/config.c
>> index 2996e6d56..fbba17483 100644
>> --- a/config.c
>> +++ b/config.c
>> @@ -2173,7 +2173,7 @@ static int write_error(const char *filename)
>> return 4;
>> }
>>
>> -struct strbuf store_create_section(const char *key)
>> +static struct strbuf store_create_section(const char *key)
>> {
>> const char *dot;
>> int i;
>> --
>> 2.13.0