git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Subject: [PATCH] config: mark a file-local symbol as static

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Jun 15, 2017, 01:20 UTC
Message-ID
<7d11fa4e-232b-8741-504f-ab4e3e788130@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Sahil,

If you need to re-roll your 'sd/branch-copy' branch, could you please squash this into the relevant patch (commit 37af9c71b6, "config: create a function to format section headers", 13-06-2017).

Also, I note that another patch in that branch (commit fd44da469c, "branch: add a --copy (-c) option to go with --move (-m)", 13-06-2017), adds a couple of external symbols which, currently, don't need to be externally visible. Is it intended that git_config_copy_section_in_file() and refs_copy_existing_ref() be part of the public API?

Thanks!

ATB, Ramsay Jones

 config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config.c b/config.c
index 2996e6d56..fbba17483 100644
--- a/config.c
+++ b/config.c
@@ -2173,7 +2173,7 @@ static int write_error(const char *filename)
 	return 4;
 }
 
-struct strbuf store_create_section(const char *key)
+static struct strbuf store_create_section(const char *key)
 {
 	const char *dot;
 	int i;
-- 
2.13.0
Next: Sahil Dua
Message 1 of 3 in “Subject: [PATCH] config: mark a file-local symbol as static”
  1. Ramsay JonesJun 15, 2017
  2. Sahil DuaJun 17, 2017
  3. Sahil DuaJun 17, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.