Re: [PATCH] mailinfo: avoid segfault when can't open files

From: Juan F. Codagnone <jcodagnone@gmail.com>
Date: Jan 24, 2018, 16:51 UTC
Message-ID: <CALfSDjd0oZZmz1nKzasKu-Adn3LPS+AdLH4mYeR=Rx-PZpe4Jw@mail.gmail.com>
In-Reply-To: <20180124040232.GB1330@sigill.intra.peff.net>

On Wed, Jan 24, 2018 at 1:02 AM, Jeff King <peff@peff.net> wrote:

>
> On Tue, Jan 23, 2018 at 11:54:17PM -0300, Juan F. Codagnone wrote:

...

Show 12 quoted lines

>
>
> But given the lack of callers, it may not be worth the effort. So I'm OK
> with this solution. It may be worth giving an abbreviated version of the
> above explanation in the commit message. Perhaps:
>
>   If <msg> or <patch> files can't be opened, then mailinfo() returns an
>   error before it even initializes mi->p_hdr_data or mi->s_hdr_data.
>   When cmd_mailinfo() then calls clear_mailinfo(), we dereference the
>   NULL pointers trying to free their contents.
>
> As for the patch itself, it looks correct but I saw two style nits:

Thanks for the detailed review! I'm sorry about the style nits. I focused on the tabs and braces. Next time I will take additional attention. I'll be resubmitting the patch taking into account your remarks.