git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] mailinfo: avoid segfault when can't open files

From
Jeff King <peff@peff.net>
Date
Jan 24, 2018, 18:06 UTC
Message-ID
<20180124180638.GA18703@sigill.intra.peff.net>
In-Reply-To
<CALfSDjd0oZZmz1nKzasKu-Adn3LPS+AdLH4mYeR=Rx-PZpe4Jw@mail.gmail.com>
On Wed, Jan 24, 2018 at 01:51:31PM -0300, Juan F. Codagnone wrote:
Show 5 quoted lines
> > As for the patch itself, it looks correct but I saw two style nits:
> 
> Thanks for the detailed review! I'm sorry about the style nits. I
> focused on the tabs and braces. Next time I will take additional
> attention.

No problem, and thank you for fixing the bug (also, I think this is your first patch, so welcome to git. :) ).

> I'll be resubmitting  the patch taking into account your remarks.
It looks good to me.
-Peff
Previous: Juan F. CodagnoneNext: Juan F. Codagnone
Message 4 of 5 in “mailinfo: avoid segfault when can't open files”
  1. mailinfo: avoid segfault when can't open filesJuan F. Codagnone, Jan 24, 2018
  2. Jeff KingJan 24, 2018
  3. Juan F. CodagnoneJan 24, 2018
  4. Jeff KingJan 24, 2018
  5. mailinfo: avoid segfault when can't open filesJuan F. Codagnone, Jan 24, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.