git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] contrib/subtree: general updates

From
Paul Campbell <pcampbell@kemitix.net>
Date
Mar 24, 2013, 00:16 UTC
Message-ID
<CALeLG_nPM4TYGAZi0mj7tGSz1hnHQXUUtwhyfodsidR2HZ_VxA@mail.gmail.com>
In-Reply-To
<7vvc8uzmht.fsf@alter.siamese.dyndns.org>
On Thu, Mar 14, 2013 at 3:30 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 16 quoted lines
> Miles Bader <miles@gnu.org> writes:
>
>> Paul Campbell <pcampbell@kemitix.net> writes:
>>> James and Michael's patches add if clauses that use the
>>> bashism 'if []' rather than 'if test'.
>>
>> "Bashism"...?  I dunno how portable is, but "[" is an old unix alias
>> for "test" ... it certainly predates bash...
>
> Correct. [[ ... ]] is new and spelling out "test" indeed is more
> traditionalist than [ ... ], but for contrib/subtree/ that does not
> work with anything but bash, I do not think such a rewrite has much
> merit in the first place.  Being consistently "bash script" (as
> opposed to being old-style) is more appropriate for it.
>
>
Does no-one have any other comments about these patches?
-- 
Paul [W] Campbell
Previous: Junio C Hamano
Message 10 of 10 in “contrib/subtree: general updates”
  1. 0/4 contrib/subtree: general updatesPaul Campbell, Mar 13, 2013
  2. 1/4 contrib/subtree: Teach push to abort if split failsPaul Campbell, Mar 13, 2013
  3. 2/4 contrib/subtree: Teach push to use --force optionPaul Campbell, Mar 13, 2013
  4. 3/4 contrib/subtree: Fix typo (s/incldued/included/)Paul Campbell, Mar 13, 2013
  5. 4/4 contrib/subtree: Replace invisible carriage return with a visible \rPaul Campbell, Mar 13, 2013
  6. Paul CampbellMar 13, 2013
  7. contrib/subtree: Replace invisible carriage return with a visible \rPaul Campbell, Mar 13, 2013
  8. Miles BaderMar 14, 2013
  9. Junio C HamanoMar 14, 2013
  10. Paul CampbellMar 24, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.