From: Paul Campbell <pcampbell@kemitix.net>
Date: Sun, 24 Mar 2013 00:16:18 GMT
Subject: Re: [PATCH 0/4] contrib/subtree: general updates
Message-ID: <CALeLG_nPM4TYGAZi0mj7tGSz1hnHQXUUtwhyfodsidR2HZ_VxA@mail.gmail.com>
In-Reply-To: <7vvc8uzmht.fsf@alter.siamese.dyndns.org>

On Thu, Mar 14, 2013 at 3:30 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Miles Bader <miles@gnu.org> writes:
>
>> Paul Campbell <pcampbell@kemitix.net> writes:
>>> James and Michael's patches add if clauses that use the
>>> bashism 'if []' rather than 'if test'.
>>
>> "Bashism"...?  I dunno how portable is, but "[" is an old unix alias
>> for "test" ... it certainly predates bash...
>
> Correct. [[ ... ]] is new and spelling out "test" indeed is more
> traditionalist than [ ... ], but for contrib/subtree/ that does not
> work with anything but bash, I do not think such a rewrite has much
> merit in the first place.  Being consistently "bash script" (as
> opposed to being old-style) is more appropriate for it.
>
>

Does no-one have any other comments about these patches?

-- 
Paul [W] Campbell