Re: [PATCH] git-submodule.sh: Support 'checkout' as a valid update command

From: Francesco Pretto <ceztko@gmail.com>
Date: Jan 7, 2014, 00:05 UTC
Message-ID: <CALas-ijrD1VnyUcr2yQw_1Je4K3eEdXtxqDNDKdGPZE=1=Nm3A@mail.gmail.com>
In-Reply-To: <xmqqtxdgfz8a.fsf@gitster.dls.corp.google.com>

2014/1/7 Junio C Hamano <gitster@pobox.com>:

Show 8 quoted lines

> Francesco Pretto <ceztko@gmail.com> writes:
>
>> According to "Documentation/gitmodules.txt", 'checkout' is a valid
>> 'submodule.<name>.update' command.
>
> As you can see in the surrounding text, we call the value of
> submodule.*.update a "mode", not a command.
>

Ok.

Show 8 quoted lines

>> Also "git-submodule.sh" refers to
>> it and processes it correctly.
>
> This present tense puzzles me.  If it already refers to checkout and
> handles it correctly is there anything that needs to be done?  Or
> did you mean "it should refer to and process it but it doesn't, so
> make it so?"
>

Like you said, "it already refers to checkout and handles it correctly". I think the use of the simple present tense here is correct: it's a fact. Feel free to advice another wording if you prefer.

Show 5 quoted lines

>> Reflecting commit 'ac1fbb' to support
>> this syntax and also validate property values during 'update' command,
>> issuing an error if the value found is unknown.
>
> Sorry, but -ECANNOTPARSE.

Not sure what's wrong here, can you explain why it's failing? I'm using git-format-patch/git-send-email with default settings. Also, if you can edit and keep the sign-off (I'm not familiar with the mailing-list maintainer workflow, sorry), feel free to do it.

Thanks