Re: [PATCH] git-submodule.sh: Support 'checkout' as a valid update command
- From
Francesco Pretto <ceztko@gmail.com>
- Date
- Jan 7, 2014, 01:16 UTC
- Message-ID
- <CALas-ijKQgDQsoNd0yrFOntnV8cuQGz8KL2xNWtYqGxXLH9q=w@mail.gmail.com>
- In-Reply-To
- <xmqqtxdgfz8a.fsf@gitster.dls.corp.google.com>
2014/1/7 Junio C Hamano <gitster@pobox.com>:
> Sorry, but -ECANNOTPARSE. >
A bird told me what -ECANNOTPARSE means. Tell me if this comment sounds better:
According to "Documentation/gitmodules.txt", 'checkout' is a valid 'submodule.<name>.update' mode. Also "git-submodule.sh" already refers to it and handles it correctly. Fix cmd_init() to also accept 'checkout' as valid update mode and add a similar validation in cmd_update(), issuing an error if the value read is unknown.