Re: [PATCH 1/2] fix clang -Wconstant-conversion with bit fields
- From
Antoine Pelisse <apelisse@gmail.com>
- Date
- Jan 16, 2013, 23:15 UTC
- Message-ID
- <CALWbr2zLZpCtcszihHcbiu5vwP6ezUd3ZLLGw2ck2aykPQpg8w@mail.gmail.com>
- In-Reply-To
- <CALWbr2ypYUvuE4pWfcVvVcnJkRvCNrM1gVHp_UXeke9gbgoE3A@mail.gmail.com>
So I guess we should drop this patch, it's probably not worth it, especially if it's been fixed already by clang.
On Thu, Jan 17, 2013 at 12:09 AM, Antoine Pelisse <apelisse@gmail.com> wrote:
Show 11 quoted lines
> On Thu, Jan 17, 2013 at 12:08 AM, John Keeping <john@keeping.me.uk> wrote: >> On Wed, Jan 16, 2013 at 11:47:22PM +0100, Antoine Pelisse wrote: >>> clang incorrectly reports a constant conversion warning (implicit >>> truncation to bit field) when using the "flag &= ~FLAG" form, because >>> ~FLAG needs to be truncated. >> Which version of clang did you see this with? I don't get these >> warnings with clang 3.2. > > Ubuntu clang version 3.0-6ubuntu3 (tags/RELEASE_30/final) (based on LLVM 3.0) > > It's good to know it's been fixed !