Re: [PATCH v2] log: grep author/committer using mailmap
- From
Antoine Pelisse <apelisse@gmail.com>
- Date
- Dec 28, 2012, 18:00 UTC
- Message-ID
- <CALWbr2y63L0-ykdUNGqUOb0LhG=vpXGRcb1KkvssEZmKFJEGeQ@mail.gmail.com>
- In-Reply-To
- <7vwqw3l49z.fsf@alter.siamese.dyndns.org>
Actually, gprof seems to be unhappy about the number of call to strbuf_grow() in map_user() (25% of the time spent in map_user() is spent in strbuf_grow()).
That probably comes from the repeated call to strbuf_addch() when lowering the email address. At this point, we are also copying the '\0' for every char we add, doubling the copy. This may not be much of a difference, but it seems to be called 15 millions times when running: $ git log --author='Junio C Hamano' --use-mailmap
Maybe we should come up with another way to lower this email address afterall.