git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] log: grep author/committer using mailmap

From
Antoine Pelisse <apelisse@gmail.com>
Date
Dec 28, 2012, 18:00 UTC
Message-ID
<CALWbr2y63L0-ykdUNGqUOb0LhG=vpXGRcb1KkvssEZmKFJEGeQ@mail.gmail.com>
In-Reply-To
<7vwqw3l49z.fsf@alter.siamese.dyndns.org>

Actually, gprof seems to be unhappy about the number of call to strbuf_grow() in map_user() (25% of the time spent in map_user() is spent in strbuf_grow()).

That probably comes from the repeated call to strbuf_addch() when lowering the email address. At this point, we are also copying the '\0' for every char we add, doubling the copy. This may not be much of a difference, but it seems to be called 15 millions times when running: $ git log --author='Junio C Hamano' --use-mailmap

Maybe we should come up with another way to lower this email address afterall.
Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 15 in “Mailmap in log improvements”
  1. 0/2 Mailmap in log improvementsAntoine Pelisse, Dec 22, 2012
  2. 1/2 log: grep author/committer using mailmapAntoine Pelisse, Dec 22, 2012
  3. Junio C HamanoDec 26, 2012
  4. Antoine PelisseDec 26, 2012
  5. Junio C HamanoDec 26, 2012
  6. log: grep author/committer using mailmapAntoine Pelisse, Dec 27, 2012
  7. Junio C HamanoDec 27, 2012
  8. Junio C HamanoDec 27, 2012
  9. Antoine PelisseDec 28, 2012
  10. Junio C HamanoDec 28, 2012
  11. Antoine PelisseDec 28, 2012
  12. 2/2 log: add log.mailmap configuration optionAntoine Pelisse, Dec 22, 2012
  13. Junio C HamanoDec 23, 2012
  14. Junio C HamanoDec 26, 2012
  15. Antoine PelisseDec 26, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.