Re: [PATCH v2] log: grep author/committer using mailmap

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 28, 2012, 18:43 UTC
Message-ID: <7va9syj9v1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CALWbr2y63L0-ykdUNGqUOb0LhG=vpXGRcb1KkvssEZmKFJEGeQ@mail.gmail.com>

Antoine Pelisse <apelisse@gmail.com> writes:

Show 6 quoted lines

> Actually, gprof seems to be unhappy about the number of call to
> strbuf_grow() in map_user() (25% of the time spent in map_user() is
> spent in strbuf_grow()).
>
> That probably comes from the repeated call to strbuf_addch() when
> lowering the email address.

This is about your rewritten implementation that hasn't escaped to the general public but sitting in 'next', right?

Two things that immediately come to mind are:

 - initialization of lowermail can use strbuf_init() instead;
 - downcasing can be done in place, i.e. "lowermail.buf[i] = ...".