git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] make commit --verbose work with --no-status

From
Tay Ray Chuan <rctay89@gmail.com>
Date
Jun 5, 2015, 16:48 UTC
Message-ID
<CALUzUxrFvE-SDW0q2P08vR7rc4GHdpm24y7dk+kUdyGGwmqwOQ@mail.gmail.com>
In-Reply-To
<xmqqbnguta69.fsf@gitster.dls.corp.google.com>
On Sat, Jun 6, 2015 at 12:03 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 26 quoted lines
> Tay Ray Chuan <rctay89@gmail.com> writes:
>
>> Would it be a good idea to have a --diff-only option to include diff,
>> but not status output? Or perhaps a --diff option, while leaving it to
>> the user to specify if status output is to be included with
>> --no-status, which would open the doors for mixing and matching status
>> formatting control, eg. with --short.
>
> The name "--diff-only" does not sound right, as people would wonder
> what should happen when you give "--status --diff-only".
>
> Perhaps you would need to do some careful thinking, similar to what
> we did when deciding the "diff" and "log" options.
>
> We originally had "--patch" and then "--patch-with-stat" to "diff"
> and "log", but soon after that people found that "show only stat
> without the patch text" is a useful thing to do.  We retrofitted the
> command line parser to take "--patch" and "--stat" as orthogonal but
> inter-related options, which was a successful conversion that did
> not break backward compatibility (These days people would not even
> know that these strangely combined forms "--patch-with-stat" and
> "--patch-with-raw" even exist).
>
> All of the above assumes that showing only the patch and not other
> hints to help situation awareness while making a commit is a useful
> thing in the first place.  I am undecided on that point myself.

Hmm, perhaps such functionality should be off-loaded to a third-party wrapper. (I'd not be surprised if most wrappers already have this.)

-- 
Cheers,
Ray Chuan
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 9 in “make commit --verbose work with --no-status”
  1. 0/2 make commit --verbose work with --no-statusTay Ray Chuan, Jun 4, 2015
  2. 1/2 extract setting of wt_status.commitable flag out of wt_status_print_updated()Tay Ray Chuan, Jun 4, 2015
  3. 2/2 make commit --verbose work with --no-statusTay Ray Chuan, Jun 4, 2015
  4. Junio C HamanoJun 4, 2015
  5. Junio C HamanoJun 4, 2015
  6. Tay Ray ChuanJun 5, 2015
  7. Junio C HamanoJun 5, 2015
  8. Tay Ray ChuanJun 5, 2015
  9. Junio C HamanoJun 5, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.