git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/2] make commit --verbose work with --no-status

From
Tay Ray Chuan <rctay89@gmail.com>
Date
Jun 4, 2015, 17:56 UTC
Message-ID
<1433440591-30917-1-git-send-email-rctay89@gmail.com>

When running git-commit`, --verbose appends a diff to the prepared message, while --no-status omits git-status output; thus, one would expect --verbose --no-status to give a commit message with a diff of the commit without git-status output.

However, this is not what happens - the prepared commit message body is empty, entirely. (Needless to say, no diff is appended.) This patch series attempts to make this work, as one would expect.

[PATCH 1/2] extract setting of wt_status.commitable flag out of wt_status_print_updated()

Currently, the wt_status.commitable flag is set only when we call wt_status_print(). * Extract this logic, so that we don't have to go through the git-status output code just to set the flag.

* In fact, it is not set when --short or --porcelain are used. This
  series does not attempt to fix the bug, though it should be trivial to
  do so with this patch. See 9cbcc2a (demonstrate git-commit --dry-run
  exit code behaviour, Feb 22 2014).
[PATCH 2/2] make commit --verbose work with --no-status
Actual work here.
-- 
2.0.0.581.g64f2558
Next: Tay Ray Chuan
Message 1 of 9 in “make commit --verbose work with --no-status”
  1. 0/2 make commit --verbose work with --no-statusTay Ray Chuan, Jun 4, 2015
  2. 1/2 extract setting of wt_status.commitable flag out of wt_status_print_updated()Tay Ray Chuan, Jun 4, 2015
  3. 2/2 make commit --verbose work with --no-statusTay Ray Chuan, Jun 4, 2015
  4. Junio C HamanoJun 4, 2015
  5. Junio C HamanoJun 4, 2015
  6. Tay Ray ChuanJun 5, 2015
  7. Junio C HamanoJun 5, 2015
  8. Tay Ray ChuanJun 5, 2015
  9. Junio C HamanoJun 5, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.