Re: [PATCH] add support for specifying an SSL cipher list

From: Tay Ray Chuan <rctay89@gmail.com>
Date: May 7, 2015, 16:42 UTC
Message-ID: <CALUzUxoC66QZ5gJdV_nE=zFOLUNfpz64Ena2rDmesaEqkEGDAQ@mail.gmail.com>
In-Reply-To: <1431008210-673-1-git-send-email-lars@redhat.com>

On Thu, May 7, 2015 at 10:16 PM, Lars Kellogg-Stedman <lars@redhat.com> wrote:

Show 18 quoted lines

> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 2e5ceaf..b17985c 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -1560,6 +1560,13 @@ http.saveCookies::
>         If set, store cookies received during requests to the file specified by
>         http.cookieFile. Has no effect if http.cookieFile is unset.
>
> +http.sslCipherList::
> +  A list of SSL ciphers to use when negotiating an SSL connection.
> +  The available ciphers depend on whether libcurl was built against
> +  NSS or OpenSSL and the particular configuration of the crypto
> +  library in use.  Can be overwridden by the 'GIT_SSL_CIPHER_LIST'
> +  environment variable.
> +
>  http.sslVerify::
>         Whether to verify the SSL certificate when fetching or pushing
>         over HTTPS. Can be overridden by the 'GIT_SSL_NO_VERIFY' environment

You might want to mention the libcurl option that this conf corresponds to, so that a reader could go look it up in the libcurl documentation to get an idea of the ciphers available, and list syntax to be used that would be accepted by us (but really by libcurl). But we also don't have to go as far as reproducing it here (eg. ciphers separated by colons) since this it tied to the libcurl version the user is linking against.

-- 
Cheers,
Ray Chuan