Re: [PATCH v3] http: add support for specifying an SSL cipher list

From: Lars Kellogg-Stedman <lars@redhat.com>
Date: May 7, 2015, 18:48 UTC
Message-ID: <20150507184804.GF16334@redhat.com>
In-Reply-To: <CAPig+cSPGguo1mEqfCTpLbHuCMaKkH8YQhoDCOPM82Fjt0C+eg@mail.gmail.com>

On Thu, May 07, 2015 at 02:41:07PM -0400, Eric Sunshine wrote:

Show 6 quoted lines

> Format multi-line comments like this:
> 
>     /*
>      * This is a multi-line
>      * comment.
>      */

Noted, thanks.

Show 5 quoted lines

> > +       if (ssl_cipherlist != NULL && ssl_cipherlist[0] != '\0')
> 
> In git code, this is usually spelled:
> 
>     if (ssl_cipherlist && *ssl_cipherlist)

Huh. At least in http.c, explicit checks against NULL seem more common:

    if (ssl_cert != NULL)
    if (ssl_key != NULL)
    if (ssl_capath != NULL)

Etc. I was just trying to make the new code look like the existing code. If nobody else has an opinion on this, I'm inclined to leave the first clause as-is so that it matches and change the check for an empty string.

-- 
Lars Kellogg-Stedman <lars@redhat.com> | larsks @ {freenode,twitter,github}
Cloud Engineering / OpenStack          | http://blog.oddbit.com/