git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/5] Tests and fixes for merge-recursive rename options

From
FAFelipe Gonçalves Assis <felipeg.assis@gmail.com>
Date
Feb 22, 2016, 22:16 UTC
Message-ID
<CALMa68qmGie+AHOWZ=BKHZOeSK9K4djiHRuooCz2h72rNZg7_A@mail.gmail.com>
In-Reply-To
<xmqqpovo5ul2.fsf@gitster.mtv.corp.google.com>
On 22 February 2016 at 18:00, Junio C Hamano <gitster@pobox.com> wrote:
Show 34 quoted lines
> "Felipe Gonçalves Assis"  <felipeg.assis@gmail.com> writes:
>
>> This is a reorganisation of the previous series, bundling the test for the fix
>> along with the commit itself, as suggested by Eric. It also includes many fixes
>> and improvements pointed out by the same reviewer, whom I thank.
>>
>> The typo fix is the same as before.
>>
>> In "add rename threshold tests", I include tests involving --find-renames,
>> except for one that depends on the fix.
>>
>> "test option to disable renames" adds tests involving --rename-threshold.
>>
>> "test deprecated interface" tests the aliasing --rename-threshold.
>>
>> In "find-renames resets threshold", the specific test for the feature was
>> bundled along.
>>
>> To Junio: Please pay special attention to the test of threshold truncation.
>> Given that it seems to be an undocumented feature, I am not sure whether it
>> should be included or not.
>>
>> Felipe Gonçalves Assis (5):
>>   merge-strategies.txt: fix typo
>>   t3034: add rename threshold tests
>>   t3034: test option to disable renames
>>   t3034: test deprecated interface
>>   merge-recursive: find-renames resets threshold
>
> As I said, I am reluctant to take the 25%/50%/75% tests in their
> current form.  Let me take the first one and a half of the last one
> (i.e. excluding the test) for now.
>
> Thanks.

Ok, should I post a new version of the patch without the tests while I rework them or does that mean that you have already filtered them out locally?

Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 11 in “Tests and fixes for merge-recursive rename options”
  1. 0/5 Tests and fixes for merge-recursive rename optionsFelipe Gonçalves Assis, Feb 21, 2016
  2. 1/5 merge-strategies.txt: fix typoFelipe Gonçalves Assis, Feb 21, 2016
  3. 2/5 t3034: add rename threshold testsFelipe Gonçalves Assis, Feb 21, 2016
  4. Junio C HamanoFeb 22, 2016
  5. 3/5 t3034: test option to disable renamesFelipe Gonçalves Assis, Feb 21, 2016
  6. 4/5 t3034: test deprecated interfaceFelipe Gonçalves Assis, Feb 21, 2016
  7. 5/5 merge-recursive: find-renames resets thresholdFelipe Gonçalves Assis, Feb 21, 2016
  8. Junio C HamanoFeb 22, 2016
  9. Felipe Gonçalves AssisFeb 22, 2016
  10. Junio C HamanoFeb 22, 2016
  11. Felipe Gonçalves AssisFeb 22, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.