From: Felipe Gonçalves Assis Date: Mon, 22 Feb 2016 22:16:09 GMT Subject: Re: [PATCH v2 0/5] Tests and fixes for merge-recursive rename options Message-ID: In-Reply-To: On 22 February 2016 at 18:00, Junio C Hamano wrote: > "Felipe Gonçalves Assis" writes: > >> This is a reorganisation of the previous series, bundling the test for the fix >> along with the commit itself, as suggested by Eric. It also includes many fixes >> and improvements pointed out by the same reviewer, whom I thank. >> >> The typo fix is the same as before. >> >> In "add rename threshold tests", I include tests involving --find-renames, >> except for one that depends on the fix. >> >> "test option to disable renames" adds tests involving --rename-threshold. >> >> "test deprecated interface" tests the aliasing --rename-threshold. >> >> In "find-renames resets threshold", the specific test for the feature was >> bundled along. >> >> To Junio: Please pay special attention to the test of threshold truncation. >> Given that it seems to be an undocumented feature, I am not sure whether it >> should be included or not. >> >> Felipe Gonçalves Assis (5): >> merge-strategies.txt: fix typo >> t3034: add rename threshold tests >> t3034: test option to disable renames >> t3034: test deprecated interface >> merge-recursive: find-renames resets threshold > > As I said, I am reluctant to take the 25%/50%/75% tests in their > current form. Let me take the first one and a half of the last one > (i.e. excluding the test) for now. > > Thanks. Ok, should I post a new version of the patch without the tests while I rework them or does that mean that you have already filtered them out locally?