git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv1 3/3] git-p4: fixing --changes-block-size handling

From
Lex Spoon <lex@lexspoon.org>
Date
Jun 7, 2015, 16:33 UTC
Message-ID
<CALM2SnbVY1baAONo3o2gb2NS+rDSsyhkPffP5EJZKU1MDA7q9w@mail.gmail.com>
In-Reply-To
<1433672505-11940-4-git-send-email-luke@diamand.org>

The implementation looks fine, especially given the test cases that back it up. I am only curious why the block size is set to a default of None. To put it as contcretely as possible: is there any expected configuration where None would work but 500 would not? We know there are many cases of the other way around, and those cases are going to send users to StackOverflow to find the right workaround.

Dropping the option would also simplify the code in several places. The complex logic around get_another_block could be removed, and instead there could be a loop from start to mostRecentCommit by block_size. Several places that check "if not block_size" could just choose the other branch.

Lex Spoon
Previous: Luke DiamandNext: Luke Diamand
Message 7 of 18 in “[PATCHv1 0/3] git-p4: fixing --changes-block-size support”
  1. Luke DiamandJun 7, 2015
  2. 1/3 git-p4: additional testing of --changes-block-sizeLuke Diamand, Jun 7, 2015
  3. Lex SpoonJun 7, 2015
  4. 2/3 git-p4: test with limited p4 server resultsLuke Diamand, Jun 7, 2015
  5. Lex SpoonJun 7, 2015
  6. 3/3 git-p4: fixing --changes-block-size handlingLuke Diamand, Jun 7, 2015
  7. Lex SpoonJun 7, 2015
  8. Luke DiamandJun 7, 2015
  9. 0/3 git-p4: fixing --changes-block-size handlingLuke Diamand, Jun 7, 2015
  10. 1/3 git-p4: additional testing of --changes-block-sizeLuke Diamand, Jun 7, 2015
  11. 2/3 git-p4: test with limited p4 server resultsLuke Diamand, Jun 7, 2015
  12. 3/3 git-p4: fixing --changes-block-size handlingLuke Diamand, Jun 7, 2015
  13. Lex SpoonJun 7, 2015
  14. Junio C HamanoJun 8, 2015
  15. Lex SpoonJun 8, 2015
  16. Lex SpoonJun 7, 2015
  17. Luke DiamandJun 7, 2015
  18. Junio C HamanoJun 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.