git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv1 0/3] git-p4: fixing --changes-block-size support

From
Luke Diamand <luke@diamand.org>
Date
Jun 7, 2015, 16:58 UTC
Message-ID
<55747846.3060305@diamand.org>
In-Reply-To
<CALM2Sna_sdD_95MO3EbF0+QSpB9W1K8Rv3-TNOmnovWG57gh7g@mail.gmail.com>
On 07/06/15 17:01, Lex Spoon wrote:
> Great work.

Thanks! I actually found the problem in my day job, so it was very handy having all the infrastructure already in place!

>
> For curiosity's sake, the -m solution has been observed to work on at
> least one Perforce installation. However clearly it doesn't work on
> others, so the batch ranges approach looks like it will be better.

Yes, I can easily imagine that it's changed from one version to the next. I tried going back to a 2014.2 server which still had the same problem (with maxresults), but my investigations were not very exhaustive!

Show 6 quoted lines
>
> Based on what has been seen so far, the Perforce maxscanrows setting
> must be applying the low-level database queries that Perforce uses
> internally in its implementation. That makes the precise effect on
> external queries rather hard to predict. It likely also depends on the
> version of Perforce.

Indeed. All sorts of things can cause it to fail; I've seen it reject "p4 files" and "p4 print", albeit with artificially low maxscanrows and maxresults values. I think this means there's no way to ever make it reliably work for all possible sizes of depot and values of maxscanrows/maxresults.

Luke
Previous: Lex SpoonNext: Junio C Hamano
Message 17 of 18 in “[PATCHv1 0/3] git-p4: fixing --changes-block-size support”
  1. Luke DiamandJun 7, 2015
  2. 1/3 git-p4: additional testing of --changes-block-sizeLuke Diamand, Jun 7, 2015
  3. Lex SpoonJun 7, 2015
  4. 2/3 git-p4: test with limited p4 server resultsLuke Diamand, Jun 7, 2015
  5. Lex SpoonJun 7, 2015
  6. 3/3 git-p4: fixing --changes-block-size handlingLuke Diamand, Jun 7, 2015
  7. Lex SpoonJun 7, 2015
  8. Luke DiamandJun 7, 2015
  9. 0/3 git-p4: fixing --changes-block-size handlingLuke Diamand, Jun 7, 2015
  10. 1/3 git-p4: additional testing of --changes-block-sizeLuke Diamand, Jun 7, 2015
  11. 2/3 git-p4: test with limited p4 server resultsLuke Diamand, Jun 7, 2015
  12. 3/3 git-p4: fixing --changes-block-size handlingLuke Diamand, Jun 7, 2015
  13. Lex SpoonJun 7, 2015
  14. Junio C HamanoJun 8, 2015
  15. Lex SpoonJun 8, 2015
  16. Lex SpoonJun 7, 2015
  17. Luke DiamandJun 7, 2015
  18. Junio C HamanoJun 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.