git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv5 9/9] t3301: Modernize

From
Johan Herland <johan@herland.net>
Date
Nov 12, 2014, 23:43 UTC
Message-ID
<CALKQrge2FM79XQy14jEYQBY+DwQ9xpcC-yMmKk1kE-yJixzJVw@mail.gmail.com>
In-Reply-To
<xmqq389o3yop.fsf@gitster.dls.corp.google.com>
On Wed, Nov 12, 2014 at 10:18 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
> Johan Herland <johan@herland.net> writes:
>> On Wed, Nov 12, 2014 at 2:57 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>>> On Tue, Nov 11, 2014 at 7:40 PM, Johan Herland <johan@herland.net> wrote:
>>>> +       test_line_count = 1 actual
>>>
>>> Broken &&-chain. This problem is repeated each place use invoke
>>> test_line_count().
>>
>> Thanks. Fixed in the next iteration.
>
> Just FYI, here is what I came up with on top of 9/9 as 10/9, and it
> can be squashed in.  If these will be the only differences between
> v5 and upcoming v6, you can just tell me to squash them together.

So far this is the only diff on top of v5. I've squashed it into my tree, so if a re-roll is needed, this diff will also be part of it. But if no other issues show up to trigger a re-roll, then please squash them on your end as well.

> One unrelated changes is that '\'' is a bit shorter than '"'"' (and
> the four-letter sequence is idiomatic and easier to spot, once your
> eyes are used to reading strings in single-quote pairs).
Agreed, thanks.
...Johan
-- 
Johan Herland, <johan@herland.net>
www.herland.net
Previous: Junio C Hamano
Message 14 of 14 in “[PATCHv5 0/9] Handling empty notes”
  1. Johan HerlandNov 12, 2014
  2. 1/9 builtin/notes: Fix premature failure when trying to add the empty blobJohan Herland, Nov 12, 2014
  3. 2/9 t3301: Verify that 'git notes' removes empty notes by defaultJohan Herland, Nov 12, 2014
  4. 3/9 builtin/notes: Improve namingJohan Herland, Nov 12, 2014
  5. 4/9 builtin/notes: Refactor note file path into struct note_dataJohan Herland, Nov 12, 2014
  6. 5/9 builtin/notes: Simplify early exit code in add()Johan Herland, Nov 12, 2014
  7. 6/9 builtin/notes: Split create_note() to clarify add vs. remove logicJohan Herland, Nov 12, 2014
  8. 7/9 builtin/notes: Add --allow-empty, to allow storing empty notesJohan Herland, Nov 12, 2014
  9. 8/9 notes: Empty notes should be shown by 'git log'Johan Herland, Nov 12, 2014
  10. 9/9 t3301: ModernizeJohan Herland, Nov 12, 2014
  11. Eric SunshineNov 12, 2014
  12. Johan HerlandNov 12, 2014
  13. Junio C HamanoNov 12, 2014
  14. Johan HerlandNov 12, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.