Re: [PATCH v2] maintenance: improve handling of lock acquisition failures
- From
Pushkar Singh <pushkarkumarsingh1970@gmail.com>
- Date
- Nov 3, 2026, 17:34 UTC
- Message-ID
- <CALE2CrTHzsMFdae6pTgXQWXKVNw3xUw+fwifz4+4RcKRgLV8wg@mail.gmail.com>
- In-Reply-To
- <auiHS_439EeHCGH6@pks.im>
[snip]
Show 6 quoted lines
> This really should be two patches now: > > - One patch that changes how we handle the failure to lock. > > - One patch that introduces your trace2 string. >
Alright, I'll split these into two separate patches.
[snip]
> Why don't you use strerror(3p) for both cases? >
Makes sense. I'll use strerror(err) consistently.
[snip]
> There's some duplication here with the auto-flag case. Can't we > deduplicate that? >
I'll clean that up as well.
[snip]
> One note though: please wait a bit before rerolling again so that others > can chime in first. You should ideally reroll at most once per day. >
Okay, I'll make sure to give some time for others to review before sending another revision from now on :-)
I'll make these changes and send the revised series tomorrow.
Thanks!
Pushkar