From: Pushkar Singh Date: Tue, 03 Nov 2026 17:34:45 GMT Subject: Re: [PATCH v2] maintenance: improve handling of lock acquisition failures Message-ID: In-Reply-To: [snip] > This really should be two patches now: > > - One patch that changes how we handle the failure to lock. > > - One patch that introduces your trace2 string. > Alright, I'll split these into two separate patches. [snip] > Why don't you use strerror(3p) for both cases? > Makes sense. I'll use strerror(err) consistently. [snip] > There's some duplication here with the auto-flag case. Can't we > deduplicate that? > I'll clean that up as well. [snip] > One note though: please wait a bit before rerolling again so that others > can chime in first. You should ideally reroll at most once per day. > Okay, I'll make sure to give some time for others to review before sending another revision from now on :-) I'll make these changes and send the revised series tomorrow. Thanks! Pushkar