Re: [PATCH] transport-helper: fix TSAN race in transfer_debug()

From: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
Date: Jun 4, 2026, 10:19 UTC
Message-ID: <CALE2CrTF_HexShFLdh-Z0zJHcyeB3jOrTxLieZS++1GVqTesjg@mail.gmail.com>
In-Reply-To: <xmqqv7bzp0vc.fsf@gitster.g>

Hi Junio,

On Thu, Jun 4, 2026 at 6:39 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Would it be possible that transfer_debug_enabled is still -1 at this
> point?  We would proceed in such a case, which is a bit different from
> what would have happened in the original.
>
> Perhaps
>
>         if (transfer_debug_enabled <= 0)
>                 return;
>
> is what you want?  I dunno.

You're right. The original code would never proceed while the value was still negative, whereas my change would.

I'll update it to use <= 0 and send a v2.

Thanks, Pushkar