git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rev-list: skip --grep argument in early scan

From
Pushkar Singh <pushkarkumarsingh1970@gmail.com>
Date
Oct 21, 2026, 15:42 UTC
Message-ID
<CALE2CrT=D8P6SksOyBudiF1En+mshxw=vdVU6KLApT0AY_ExsA@mail.gmail.com>
In-Reply-To
<20261021151253.3689-1-azuama69@gmail.com>
Hi,
Thanks for the patch!

One thing I noticed is that the commit message doesn't have a description. Could you add a bit of context about the issue you're fixing and why this change is needed? It'll make it easier for others to understand the reason behind the patch.

> +               } else if (!strcmp(arg, "--grep")) {
> +                       i++;

Also, could you check if the first scan needs similar handling? With --grep --exclude-promisor-objects, the first scan might treat --exclude-promisor-objects as an option instead of the pattern argument to --grep. A test for this case would help confirm whether the fix covers both scans.

Thanks!
- Pushkar
Previous: Azuama Odinaka MaximusNext: Azuama Odinaka Maximus
Message 2 of 11 in “rev-list: skip --grep argument in early scan”
  1. rev-list: skip --grep argument in early scanAzuama Odinaka Maximus, Oct 21, 2026
  2. Pushkar SinghOct 21, 2026
  3. rev-list: skip --grep argument in early scanAzuama Odinaka Maximus, Oct 21, 2026
  4. Pushkar SinghOct 22, 2026
  5. Junio C HamanoOct 23, 2026
  6. rev-list: skip --grep argument in early scanAzuama Odinaka Maximus, Oct 26, 2026
  7. Tanga JorisNov 5, 2026
  8. rev-list: handle arguments in early option scanAzuama Odinaka Maximus, Nov 5, 2026
  9. Junio C HamanoNov 6, 2026
  10. Azuama Odinaka MaximusNov 6, 2026
  11. Junio C HamanoNov 6, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.