From: Pushkar Singh Date: Wed, 21 Oct 2026 15:42:37 GMT Subject: Re: [PATCH] rev-list: skip --grep argument in early scan Message-ID: In-Reply-To: <20261021151253.3689-1-azuama69@gmail.com> Hi, Thanks for the patch! One thing I noticed is that the commit message doesn't have a description. Could you add a bit of context about the issue you're fixing and why this change is needed? It'll make it easier for others to understand the reason behind the patch. > + } else if (!strcmp(arg, "--grep")) { > + i++; Also, could you check if the first scan needs similar handling? With --grep --exclude-promisor-objects, the first scan might treat --exclude-promisor-objects as an option instead of the pattern argument to --grep. A test for this case would help confirm whether the fix covers both scans. Thanks! - Pushkar