git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] builtin/repo: improve counting of objects

From
Kristofer Karlsson <krka@spotify.com>
Date
Nov 16, 2026, 09:07 UTC
Message-ID
<CAL71e4OcVOS4LPeNmLmF-92PMB_NC5NNZieAdGB15g4Yr7n01g@mail.gmail.com>
In-Reply-To
<20261116-pks-repo-count-objects-speedup-v2-0-9c8be218eaff@pks.im>
On Mon, 16 Nov 2026 at 09:01, Patrick Steinhardt <ps@pks.im> wrote:
Show 17 quoted lines
>
> Range-diff versus v1:
>
> 1:  a7a1c1a8041 ! 1:  2780e491ead builtin/repo: only parse objects as needed
>     @@ builtin/repo.c: static int count_objects(const char *path UNUSED, struct oid_arr
>                 case OBJ_COMMIT:
>      -                  commit = object_as_type(obj, OBJ_COMMIT, 0);
>      +                  /*
>     -+                   * Commits have already been parsed by the revision
>     -+                   * walk, so there is no need to read their contents
>     -+                   * again.
>     ++                   * Commits should already have been parsed by the
>     ++                   * revision walk, so in theory we do not need to read
>     ++                   * their contents again.
>      +                   */
>      +                  commit = lookup_commit(data->odb->repo, &oids->oid[i]);
>      +                  if (!commit || repo_parse_commit(data->odb->repo, commit))

I think this range-diff addresses my only nit, so I am happy with this version!

Thanks, Kristofer

Previous: Patrick SteinhardtNext: Derrick Stolee
Message 13 of 15 in “builtin/repo: improve counting of objects”
  1. 0/2 builtin/repo: improve counting of objectsPatrick Steinhardt, Nov 13, 2026
  2. 1/2 builtin/repo: only parse objects as neededPatrick Steinhardt, Nov 13, 2026
  3. Kristofer KarlssonNov 13, 2026
  4. Patrick SteinhardtNov 16, 2026
  5. Kristofer KarlssonNov 16, 2026
  6. 2/2 builtin/repo: don't fully parse treesPatrick Steinhardt, Nov 13, 2026
  7. Kristofer KarlssonNov 13, 2026
  8. Patrick SteinhardtNov 16, 2026
  9. Derrick StoleeNov 16, 2026
  10. 0/2 builtin/repo: improve counting of objectsPatrick Steinhardt, Nov 16, 2026
  11. 1/2 builtin/repo: only parse objects as neededPatrick Steinhardt, Nov 16, 2026
  12. 2/2 builtin/repo: don't fully parse treesPatrick Steinhardt, Nov 16, 2026
  13. Kristofer KarlssonNov 16, 2026
  14. Derrick StoleeNov 16, 2026
  15. Junio C HamanoNov 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.