Re: [PATCH 1/2] builtin/repo: only parse objects as needed
- From
Kristofer Karlsson <krka@spotify.com>
- Date
- Nov 13, 2026, 14:12 UTC
- Message-ID
- <CAL71e4NfnYLAXQT-wpb6ciJZwTrT51EZVsEs8VertN=xBmUD_g@mail.gmail.com>
- In-Reply-To
- <20261113-pks-repo-count-objects-speedup-v1-1-7ba4f29e74fb@pks.im>
On Fri, 13 Nov 2026 at 13:50, Patrick Steinhardt <ps@pks.im> wrote:
Show 9 quoted lines
> > + /* > + * Commits have already been parsed by the revision > + * walk, so there is no need to read their contents > + * again. > + */ > + commit = lookup_commit(data->odb->repo, &oids->oid[i]); > + if (!commit || repo_parse_commit(data->odb->repo, commit)) > + continue;
Tiny nit: I understood the comment as saying that the code depends on the commits being parsed already, but repo_parse_commit() handles the case where they are not. Since path-walk hands us commits from get_revision(), I assume that is only a failsafe? So this is just about the phrasing. How about:
/* * Commits should already have been parsed by the * revision walk, so we do not need to read their * contents again. */
Otherwise this looks good to me. Only reading contents for trees avoids inflating every blob just to throw it away, which is a nice easy win.
Thanks, Kristofer