git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 00/23] backend-struct-db

From
Ronnie Sahlberg <sahlberg@google.com>
Date
Aug 13, 2014, 21:55 UTC
Message-ID
<CAL=YDWkg1D1JyBhT0Jr4ur+fv3rp9tGm+a-gSYBaixaAHKQ_EQ@mail.gmail.com>
In-Reply-To
<xmqqmwb82im7.fsf@gitster.dls.corp.google.com>
On Wed, Aug 13, 2014 at 2:18 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 22 quoted lines
> Ronnie Sahlberg <sahlberg@google.com> writes:
>
>> 15 of the patches, the refs-common.c patches, focuses on moving all backend
>> agnostic refs functions to a common file. This file will contain all
>> backend agnostic refs functions.
>>
>> The last 6 patches adds a backend structure with the methods we need to
>> describe a pluggable backend. Currently we only have one built in backend,
>> the current files based backend. These patches do not change any of the
>> behavior other than that we now call the methods through backend specific
>> wrapper functions rather than calling them directly.
>>
>> At this stage we now have a defined set of methods needed for a refs
>> backend and we can start building and adding new types of ref backends
>> to git.
>
> Very nice ;-).
>
> I would have expected that refs.c would be the generic one and refs-be-*
> would be the backend specific ones, though; that way you do not have to
> introduce a new file refs-common.c at all, no?
>

Makes sense. Let me do those changes and then I will re-post sometime next week once I get additional feedback on it.

regards Ronnie Sahlberg

Previous: Junio C Hamano
Message 27 of 27 in “backend-struct-db”
  1. 00/23 backend-struct-dbRonnie Sahlberg, Aug 13, 2014
  2. 01/23 refs.c: create a public function for is_refname_availableRonnie Sahlberg, Aug 13, 2014
  3. 02/23 refs-common.c: create a file to host all common refs codeRonnie Sahlberg, Aug 13, 2014
  4. 03/23 refs-common.c: move update_ref to refs-common.cRonnie Sahlberg, Aug 13, 2014
  5. 04/23 refs-common.c: move delete_ref to the common codeRonnie Sahlberg, Aug 13, 2014
  6. 05/23 refs-common.c: move rename_ref to the common codeRonnie Sahlberg, Aug 13, 2014
  7. 06/23 refs-common.c: move read_ref_at to the refs common fileRonnie Sahlberg, Aug 13, 2014
  8. 07/23 refs-common.c: move the hidden refs functions to the common codeRonnie Sahlberg, Aug 13, 2014
  9. 08/23 refs-common.c: move dwim and friend functions to refs commonRonnie Sahlberg, Aug 13, 2014
  10. 09/23 refs-common.c: move warn_if_dangling_symref* to refs-commonRonnie Sahlberg, Aug 13, 2014
  11. 10/23 refs-common.c: move read_ref, read_ref_full and ref_exists to commonRonnie Sahlberg, Aug 13, 2014
  12. 11/23 refs-common.c: move resolve_refdup to commonRonnie Sahlberg, Aug 13, 2014
  13. 12/23 refs-common.c: move check_refname_component to the common codeRonnie Sahlberg, Aug 13, 2014
  14. 13/23 refs-common.c: move is_branch to the common codeRonnie Sahlberg, Aug 13, 2014
  15. 14/23 refs-common.c: move names_conflict to the common codeRonnie Sahlberg, Aug 13, 2014
  16. 15/23 refs-common.c: move prettify_refname to the common codeRonnie Sahlberg, Aug 13, 2014
  17. 16/23 refs-common.c: move ref iterators to the common codeRonnie Sahlberg, Aug 13, 2014
  18. 17/23 refs-common.c: move head_ref_namespaced to the common fileRonnie Sahlberg, Aug 13, 2014
  19. 18/23 refs.c: add a backend method structure with transaction functionsRonnie Sahlberg, Aug 13, 2014
  20. Junio C HamanoAug 26, 2014
  21. Ronnie SahlbergAug 26, 2014
  22. 19/23 refs.c: add reflog backend methodsRonnie Sahlberg, Aug 13, 2014
  23. 20/23 refs.c: add methods for misc ref operationsRonnie Sahlberg, Aug 13, 2014
  24. 21/23 refs.c: add methods for head_ref*Ronnie Sahlberg, Aug 13, 2014
  25. 22/23 refs.c: add methods for the ref iteratorsRonnie Sahlberg, Aug 13, 2014
  26. Junio C HamanoAug 13, 2014
  27. Ronnie SahlbergAug 13, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.