git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 22/23] refs.c: add methods for the ref iterators

From
Ronnie Sahlberg <sahlberg@google.com>
Date
Aug 13, 2014, 20:15 UTC
Message-ID
<1407960907-18189-23-git-send-email-sahlberg@google.com>
In-Reply-To
<1407960907-18189-1-git-send-email-sahlberg@google.com>
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
---
 refs-common.c | 36 ++++++++++++++++++++++++++++++++++++
 refs.c        | 21 ++++++++++++++-------
 refs.h        | 19 +++++++++++++++++++
 3 files changed, 69 insertions(+), 7 deletions(-)
diff --git a/refs-common.c b/refs-common.c
index f19402b..3df725d 100644
--- a/refs-common.c
+++ b/refs-common.c
@@ -928,3 +928,39 @@ int head_ref_submodule(const char *submodule, each_ref_fn fn, void *cb_data)
 {
 	return refs->head_ref_submodule(submodule, fn, cb_data);
 }
+ 
+int for_each_ref(each_ref_fn fn, void *cb_data)
+{
+	return refs->for_each_ref(fn, cb_data);
+}
+
+int for_each_ref_submodule(const char *submodule, each_ref_fn fn, void *cb_data)
+{
+	return refs->for_each_ref_submodule(submodule, fn, cb_data);
+}
+
+int for_each_ref_in(const char *prefix, each_ref_fn fn, void *cb_data)
+{
+	return refs->for_each_ref_in(prefix, fn, cb_data);
+}
+
+int for_each_ref_in_submodule(const char *submodule, const char *prefix,
+			      each_ref_fn fn, void *cb_data)
+{
+	return refs->for_each_ref_in_submodule(submodule, prefix, fn, cb_data);
+}
+
+int for_each_rawref(each_ref_fn fn, void *cb_data)
+{
+	return refs->for_each_rawref(fn, cb_data);
+}
+
+int for_each_namespaced_ref(each_ref_fn fn, void *cb_data)
+{
+	return refs->for_each_namespaced_ref(fn, cb_data);
+}
+
+int for_each_replace_ref(each_ref_fn fn, void *cb_data)
+{
+	return refs->for_each_replace_ref(fn, cb_data);
+}
diff --git a/refs.c b/refs.c
index 7ad07f1..dc0467a 100644
--- a/refs.c
+++ b/refs.c
@@ -1610,33 +1610,33 @@ static int files_head_ref_submodule(const char *submodule, each_ref_fn fn, void
 	return do_head_ref(submodule, fn, cb_data);
 }
 
-int for_each_ref(each_ref_fn fn, void *cb_data)
+static int files_for_each_ref(each_ref_fn fn, void *cb_data)
 {
 	return do_for_each_ref(&ref_cache, "", fn, 0, 0, cb_data);
 }
 
-int for_each_ref_submodule(const char *submodule, each_ref_fn fn, void *cb_data)
+static int files_for_each_ref_submodule(const char *submodule, each_ref_fn fn, void *cb_data)
 {
 	return do_for_each_ref(get_ref_cache(submodule), "", fn, 0, 0, cb_data);
 }
 
-int for_each_ref_in(const char *prefix, each_ref_fn fn, void *cb_data)
+static int files_for_each_ref_in(const char *prefix, each_ref_fn fn, void *cb_data)
 {
 	return do_for_each_ref(&ref_cache, prefix, fn, strlen(prefix), 0, cb_data);
 }
 
-int for_each_ref_in_submodule(const char *submodule, const char *prefix,
+static int files_for_each_ref_in_submodule(const char *submodule, const char *prefix,
 		each_ref_fn fn, void *cb_data)
 {
 	return do_for_each_ref(get_ref_cache(submodule), prefix, fn, strlen(prefix), 0, cb_data);
 }
 
-int for_each_replace_ref(each_ref_fn fn, void *cb_data)
+static int files_for_each_replace_ref(each_ref_fn fn, void *cb_data)
 {
 	return do_for_each_ref(&ref_cache, "refs/replace/", fn, 13, 0, cb_data);
 }
 
-int for_each_namespaced_ref(each_ref_fn fn, void *cb_data)
+static int files_for_each_namespaced_ref(each_ref_fn fn, void *cb_data)
 {
 	struct strbuf buf = STRBUF_INIT;
 	int ret;
@@ -1646,7 +1646,7 @@ int for_each_namespaced_ref(each_ref_fn fn, void *cb_data)
 	return ret;
 }
 
-int for_each_rawref(each_ref_fn fn, void *cb_data)
+static int files_for_each_rawref(each_ref_fn fn, void *cb_data)
 {
 	return do_for_each_ref(&ref_cache, "", fn, 0,
 			       DO_FOR_EACH_INCLUDE_BROKEN, cb_data);
@@ -3311,6 +3311,13 @@ struct ref_be refs_files = {
 	files_resolve_gitlink_ref,
 	files_head_ref,
 	files_head_ref_submodule,
+	files_for_each_ref,
+	files_for_each_ref_submodule,
+	files_for_each_ref_in,
+	files_for_each_ref_in_submodule,
+	files_for_each_rawref,
+	files_for_each_namespaced_ref,
+	files_for_each_replace_ref,
 };
 
 struct ref_be *refs = &refs_files;
diff --git a/refs.h b/refs.h
index 420e9b5..249a14a 100644
--- a/refs.h
+++ b/refs.h
@@ -401,6 +401,18 @@ typedef int (*head_ref_fn)(each_ref_fn fn, void *cb_data);
 typedef int (*head_ref_submodule_fn)(const char *submodule, each_ref_fn fn,
 				     void *cb_data);
 
+typedef int (*for_each_ref_fn)(each_ref_fn fn, void *cb_data);
+typedef int (*for_each_ref_submodule_fn)(const char *submodule, each_ref_fn fn,
+					 void *cb_data);
+typedef int (*for_each_ref_in_fn)(const char *prefix, each_ref_fn fn,
+				  void *cb_data);
+typedef int (*for_each_ref_in_submodule_fn)(const char *submodule,
+					    const char *prefix,
+					    each_ref_fn fn, void *cb_data);
+typedef int (*for_each_rawref_fn)(each_ref_fn fn, void *cb_data);
+typedef int (*for_each_namespaced_ref_fn)(each_ref_fn fn, void *cb_data);
+typedef int (*for_each_replace_ref_fn)(each_ref_fn fn, void *cb_data);
+
 struct ref_be {
 	transaction_begin_fn transaction_begin;
 	transaction_update_sha1_fn transaction_update_sha1;
@@ -423,6 +435,13 @@ struct ref_be {
 	resolve_gitlink_ref_fn resolve_gitlink_ref;
 	head_ref_fn head_ref;
 	head_ref_submodule_fn head_ref_submodule;
+	for_each_ref_fn for_each_ref;
+	for_each_ref_submodule_fn for_each_ref_submodule;
+	for_each_ref_in_fn for_each_ref_in;
+	for_each_ref_in_submodule_fn for_each_ref_in_submodule;
+	for_each_rawref_fn for_each_rawref;
+	for_each_namespaced_ref_fn for_each_namespaced_ref;
+	for_each_replace_ref_fn for_each_replace_ref;
 };
 
 extern struct ref_be *refs;
-- 
2.0.1.556.g3edca4c
Previous: Ronnie SahlbergNext: Junio C Hamano
Message 25 of 27 in “backend-struct-db”
  1. 00/23 backend-struct-dbRonnie Sahlberg, Aug 13, 2014
  2. 01/23 refs.c: create a public function for is_refname_availableRonnie Sahlberg, Aug 13, 2014
  3. 02/23 refs-common.c: create a file to host all common refs codeRonnie Sahlberg, Aug 13, 2014
  4. 03/23 refs-common.c: move update_ref to refs-common.cRonnie Sahlberg, Aug 13, 2014
  5. 04/23 refs-common.c: move delete_ref to the common codeRonnie Sahlberg, Aug 13, 2014
  6. 05/23 refs-common.c: move rename_ref to the common codeRonnie Sahlberg, Aug 13, 2014
  7. 06/23 refs-common.c: move read_ref_at to the refs common fileRonnie Sahlberg, Aug 13, 2014
  8. 07/23 refs-common.c: move the hidden refs functions to the common codeRonnie Sahlberg, Aug 13, 2014
  9. 08/23 refs-common.c: move dwim and friend functions to refs commonRonnie Sahlberg, Aug 13, 2014
  10. 09/23 refs-common.c: move warn_if_dangling_symref* to refs-commonRonnie Sahlberg, Aug 13, 2014
  11. 10/23 refs-common.c: move read_ref, read_ref_full and ref_exists to commonRonnie Sahlberg, Aug 13, 2014
  12. 11/23 refs-common.c: move resolve_refdup to commonRonnie Sahlberg, Aug 13, 2014
  13. 12/23 refs-common.c: move check_refname_component to the common codeRonnie Sahlberg, Aug 13, 2014
  14. 13/23 refs-common.c: move is_branch to the common codeRonnie Sahlberg, Aug 13, 2014
  15. 14/23 refs-common.c: move names_conflict to the common codeRonnie Sahlberg, Aug 13, 2014
  16. 15/23 refs-common.c: move prettify_refname to the common codeRonnie Sahlberg, Aug 13, 2014
  17. 16/23 refs-common.c: move ref iterators to the common codeRonnie Sahlberg, Aug 13, 2014
  18. 17/23 refs-common.c: move head_ref_namespaced to the common fileRonnie Sahlberg, Aug 13, 2014
  19. 18/23 refs.c: add a backend method structure with transaction functionsRonnie Sahlberg, Aug 13, 2014
  20. Junio C HamanoAug 26, 2014
  21. Ronnie SahlbergAug 26, 2014
  22. 19/23 refs.c: add reflog backend methodsRonnie Sahlberg, Aug 13, 2014
  23. 20/23 refs.c: add methods for misc ref operationsRonnie Sahlberg, Aug 13, 2014
  24. 21/23 refs.c: add methods for head_ref*Ronnie Sahlberg, Aug 13, 2014
  25. 22/23 refs.c: add methods for the ref iteratorsRonnie Sahlberg, Aug 13, 2014
  26. Junio C HamanoAug 13, 2014
  27. Ronnie SahlbergAug 13, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.