Re: [PATCH] ls-files: add pathspec matching for submodules

From: Brandon Williams <bmwill@google.com>
Date: Sep 19, 2016, 18:30 UTC
Message-ID: <CAKoko1rULusRdcw7_u0QRfn590uTAZyOTk4JS6b8oopaSDLNDQ@mail.gmail.com>
In-Reply-To: <xmqqshsveomv.fsf@gitster.mtv.corp.google.com>

side question if the answer is short: Any reason as to why all of the pathspec matching code lives inside of dir.c and not pathspec.c?

On Mon, Sep 19, 2016 at 11:22 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> Brandon Williams <bmwill@google.com> writes:
>
>> Yes in that case it wouldn't have passed ps_strncmp()...but we should have never
>> made it there in the first place due to a piece of logic in match_pathspec_item:
>
> Ah, OK.
>
> Thanks for clarifying.