git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] Fix the order of consuming unpackLimit config settings.

From
TSTaylor Santiago <taylorsantiago@google.com>
Date
Aug 23, 2023, 03:32 UTC
Message-ID
<CAKacvadHXrgVmAfT_W+wPyhhRP2hVXXcVRB3rX8ArKvqUpe=Ug@mail.gmail.com>
In-Reply-To
<xmqqcyzeh6a2.fsf@gitster.g>
Looks good to me.

Thanks for the info on the patch process. I also am sending this mail in plain text mode so hopefully the mailing list doesn't drop it.

On Tue, Aug 22, 2023 at 6:55 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 33 quoted lines
>
> Taylor Santiago <taylorsantiago@google.com> writes:
>
> > Thank you! How would you like me to proceed? Should I submit the above as a
> > v2 of the earlier patch?
>
> There is nothing "above" as you seem to be top posting ;-)
>
> When somebody else helps by supplying an "squashable" patch, often
> people are expected to review it and then update their patch(es)
> using the given material to produce a v2.
>
> But as I said, the "squashable" one was only about the receive-pack
> side; even if you combined it with your original, tests for the
> fetch side were still missing, so it was not sufficient for a v2.
>
> As I didn't see your reply message (to which I am responding to)
> until now, mostly because it was dropped by the mailing list
> (perhaps it was an HTML e-mail from GMail or something???), I've
> further worked on the tests to cover the fetch side and sent out a
> full version (not a squashable, but just a replacement for the whole
> thing).  It is archived and viewable at
>
>   https://lore.kernel.org/git/xmqqpm3eh7f6.fsf@gitster.g
>
> Part of it is still your original patch, some material in its
> proposed commit log message was given by Peff, and the rest was
> written by me, so it carries names of three people.
>
> If the result looks acceptable to you, then saying "Yup, that looks
> good" would be the simplest answer to give to move things forward.
>
> Thanks.
Previous: Junio C Hamano
Message 8 of 8 in “Fix the order of consuming unpackLimit config settings.”
  1. 0/1 Fix the order of consuming unpackLimit config settings.Taylor Santiago, Aug 17, 2023
  2. 1/1 Fix the order of consuming unpackLimit config settings.Taylor Santiago, Aug 17, 2023
  3. Jeff KingAug 21, 2023
  4. Junio C HamanoAug 22, 2023
  5. Junio C HamanoAug 23, 2023
  6. Jeff KingAug 23, 2023
  7. Junio C HamanoAug 23, 2023
  8. Taylor SantiagoAug 23, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.