git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/1] Fix the order of consuming unpackLimit config settings.

From
TSTaylor Santiago <taylorsantiago@google.com>
Date
Aug 17, 2023, 21:53 UTC
Message-ID
<20230817215325.2550998-2-taylorsantiago@google.com>
In-Reply-To
<20230817215325.2550998-1-taylorsantiago@google.com>

The documentation for fetch.unpackLimit states that fetch.unpackLimit should be treated as higher priority than transfer.unpackLimit, but the intended order is currently inverted.

Signed-off-by: Taylor Santiago <taylorsantiago@google.com>
---
 fetch-pack.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fetch-pack.c b/fetch-pack.c
index 65c1ff4bb4..26999e3b65 100644
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -1911,10 +1911,10 @@ static void fetch_pack_setup(void)
 	if (did_setup)
 		return;
 	fetch_pack_config();
-	if (0 <= transfer_unpack_limit)
-		unpack_limit = transfer_unpack_limit;
-	else if (0 <= fetch_unpack_limit)
+	if (0 <= fetch_unpack_limit)
 		unpack_limit = fetch_unpack_limit;
+	else if (0 <= transfer_unpack_limit)
+		unpack_limit = transfer_unpack_limit;
 	did_setup = 1;
 }
 
-- 
2.41.0.694.ge786442a9b-goog
Previous: Taylor SantiagoNext: Jeff King
Message 2 of 8 in “Fix the order of consuming unpackLimit config settings.”
  1. 0/1 Fix the order of consuming unpackLimit config settings.Taylor Santiago, Aug 17, 2023
  2. 1/1 Fix the order of consuming unpackLimit config settings.Taylor Santiago, Aug 17, 2023
  3. Jeff KingAug 21, 2023
  4. Junio C HamanoAug 22, 2023
  5. Junio C HamanoAug 23, 2023
  6. Jeff KingAug 23, 2023
  7. Junio C HamanoAug 23, 2023
  8. Taylor SantiagoAug 23, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.