Re: [GIT GUI PATCH 0/2] teach git gui to open the configured editor

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Mar 25, 2012, 19:33 UTC
Message-ID: <CAKPyHN3xtd2S4n3En18xAwgwDYGHOfNyFnXMkVc4V-kxq+myEA@mail.gmail.com>
In-Reply-To: <20120325170200.GC38866@book.hvoigt.net>

On Sun, Mar 25, 2012 at 19:02, Heiko Voigt <hvoigt@hvoigt.net> wrote:

Show 23 quoted lines

> Hi,
>
> On Fri, Mar 23, 2012 at 07:43:32PM +0100, Bert Wesarg wrote:
>> On Fri, Mar 23, 2012 at 18:30, Heiko Voigt <hvoigt@hvoigt.net> wrote:
>> > This patch series adds a new right click menuitem which allows the user
>> > to open the configured editor with the currently viewed file. For some
>> > popular editors it is also able to move the cursor close to the watched
>> > line.
>>
>> I once mentioned this in a patch I send ages ago:
>>
>> <1289770869-11665-1-git-send-email-bert.wesarg@googlemail.com>
>>
>> Look for the '[1]' reference.
>>
>> I have done, what was discussed in this thread, but never send
>> something to the list (maybe a private mail to Pat?), but you can have
>> a look at my git-gui repo at [1]. The patch which implements this is
>> bw/master~5 (a648f3a06 'git-gui: open file with GIT_EDITOR').
>
> Interesting, I will give it a try once I find some time. So do you think
> it is now ready for inclusion? I saw that you actually did a lot more
> than me.

You're right, in this commit is more than it should, I split it up. Thanks. I had the action also only on mouse button 2 (ie. middle one) but I added it now to the menus too. You have missed yourself a menu, that what is used for a merge conflict. And I added a menu to the file lists too, so they have a 'Open in Editor' entry now too.

Bert

>
> Cheers Heiko
>