Re: [GIT GUI PATCH 0/2] teach git gui to open the configured editor

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Mar 23, 2012, 18:43 UTC
Message-ID: <CAKPyHN1SWLMKtWOPJ7NwcwuE2Kpwb84yz443P7R=vE4jSPFEOw@mail.gmail.com>
In-Reply-To: <cover.1332523097.git.hvoigt@hvoigt.net>

Hi,

On Fri, Mar 23, 2012 at 18:30, Heiko Voigt <hvoigt@hvoigt.net> wrote:

> This patch series adds a new right click menuitem which allows the user
> to open the configured editor with the currently viewed file. For some
> popular editors it is also able to move the cursor close to the watched
> line.

I once mentioned this in a patch I send ages ago:

<1289770869-11665-1-git-send-email-bert.wesarg@googlemail.com>

Look for the '[1]' reference.

I have done, what was discussed in this thread, but never send something to the list (maybe a private mail to Pat?), but you can have a look at my git-gui repo at [1]. The patch which implements this is bw/master~5 (a648f3a06 'git-gui: open file with GIT_EDITOR').

Regards, Bert

[1] http://repo.or.cz/w/git-gui/bertw.git

Show 24 quoted lines

>
> Please have a look at the parsing of the configured editor commandline.
> I tested it for most situations. Maybe someone has an idea for a more
> elegant way to split up between arguments and command.
>
> Currently I substitute all ' with " and then abuse the lindex command for
> trimming and splitting.
>
> Cheers Heiko
>
> Heiko Voigt (2):
>  git-gui: teach _which procedure to work with absolute paths
>  git-gui: add "open in editor" diff context menu entry
>
>  git-gui/git-gui.sh |   55 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 55 insertions(+)
>
> --
> 1.7.10.rc1.29.gf035d
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html