git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Submodules always use a relative path to gitdir

From
Fredrik Gustafsson <iveqy@iveqy.com>
Date
Dec 29, 2011, 22:48 UTC
Message-ID
<CAJmizVZ_n9KmKWwDeLuYxBTWvndh5cTcvUbFduOtEcOPL=_WeQ@mail.gmail.com>
In-Reply-To
<1325192426-10103-1-git-send-email-antony.male@gmail.com>

2011/12/29 Antony Male <antony.male@gmail.com>: <snip>

>                die "$(eval_gettext "Clone of '\$url' into submodule path '\$path' failed")"
>        fi
> +       echo "gitdir: $rel_gitdir" >"$path/.git"

This will replace an already created file. Is it really the best solution to create a gitfile with an absolute path and after that replace it with a relative path. Why not write the relative path from the beginning?

The patch also breaks two tests: t7406 and t5526.

Regards Fredrik

Previous: Junio C HamanoNext: Phil Hord
Message 15 of 16 in “Submodules always use a relative path to gitdir”
  1. Submodules always use a relative path to gitdirAntony Male, Dec 29, 2011
  2. Junio C HamanoDec 29, 2011
  3. Phil HordDec 31, 2011
  4. Junio C HamanoJan 3, 2012
  5. Junio C HamanoJan 3, 2012
  6. Jens LehmannJan 1, 2012
  7. Junio C HamanoJan 3, 2012
  8. Jens LehmannJan 3, 2012
  9. Junio C HamanoJan 3, 2012
  10. Jens LehmannJan 5, 2012
  11. Junio C HamanoJan 6, 2012
  12. Phil HordJan 6, 2012
  13. Nguyen Thai Ngoc DuyJan 6, 2012
  14. Junio C HamanoJan 6, 2012
  15. Fredrik GustafssonDec 29, 2011
  16. Phil HordDec 31, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.