From: Fredrik Gustafsson <iveqy@iveqy.com>
Date: Thu, 29 Dec 2011 22:48:41 GMT
Subject: Re: [PATCH] Submodules always use a relative path to gitdir
Message-ID: <CAJmizVZ_n9KmKWwDeLuYxBTWvndh5cTcvUbFduOtEcOPL=_WeQ@mail.gmail.com>
In-Reply-To: <1325192426-10103-1-git-send-email-antony.male@gmail.com>

2011/12/29 Antony Male <antony.male@gmail.com>:
<snip>
>                die "$(eval_gettext "Clone of '\$url' into submodule path '\$path' failed")"
>        fi
> +       echo "gitdir: $rel_gitdir" >"$path/.git"

This will replace an already created file. Is it really the best
solution to create a gitfile with an absolute path and after that
replace it with a relative path. Why not write the relative path from
the beginning?

The patch also breaks two tests:
t7406 and t5526.

Regards
Fredrik