Re: [PATCH v3] diff-lib: Fix check_removed when fsmonitor is on

From: Josip Sokcevic <sokcevic@google.com>
Date: Sep 12, 2023, 03:03 UTC
Message-ID: <CAJiyOijMvqK184wFgoXFyX5kmURkX3k2OmuiBpArikj26iHpMA@mail.gmail.com>
In-Reply-To: <xmqqsf7ks4nn.fsf@gitster.g>

On Mon, Sep 11, 2023 at 3:53 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> This certainly is more "complete" if simpler than the previous one
> ;-)
>
> In the longer term, we would probably want to enable optimization
> using what fsmonitor knows, but as we have seen in the review on
> the previous round, this code needs a bit more work than the
> original we are reverting here to get it right, and in the shorter
> term, hopefully this would do.

Yes, I agree we should optimize this in a follow up. One thing I'm not sure about is if we should try to construct `struct stat` using `cache_index`, or we should check for `CE_FSMONITOR_VALID` in a way that `stat` would no longer be needed for those code paths.

-- 
Josip Sokcevic