Re: [PATCH 1/2] rebase -i: optimize the creation of the todo file
- From
Dominique Quatravaux <domq@google.com>
- Date
- Mar 8, 2012, 11:36 UTC
- Message-ID
- <CAJh6GrGch9JHYnGW+K-wxdX9wPRry4Lxi2ysTtt0g9FTF4ThTQ@mail.gmail.com>
- In-Reply-To
- <4F589611.6060106@viscovery.net>
On Thu, Mar 8, 2012 at 12:20 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
Show 7 quoted lines
> Am 3/8/2012 11:42, schrieb Dominique Quatravaux: >> + shortsha1=$(echo $sha1 | cut -c1-7) > >> - sha1=$(git rev-parse $shortsha1) > > Why do you call it "optimization" when you spend two or three subprocesses > instead of one?
echo is a shell internal. "git rev-parse" is two processes just as "cut" and a pipe. The difference is that cut doesn't hit the git repository.
But the real purpose of this first change is to lay the ground for the next one, so I'd be happy to change the patch description...
-- Dominique Quatravaux +41 79 609 40 72