Re: [PATCH v6 6/6] clean: teach clean -d to preserve ignored paths

From: Samuel Lijin <sxlijin@gmail.com>
Date: May 25, 2017, 15:36 UTC
Message-ID: <CAJZjrdXZkxjHt3XFFhS2BDWwwW8Gmz7frfbUzxgBBwcFYBZe3Q@mail.gmail.com>
In-Reply-To: <517a9182-0366-d51a-b7e5-f9085df5b4f9@web.de>

On Wed, May 24, 2017 at 12:14 AM, Torsten Bögershausen <tboegi@web.de> wrote:

Show 13 quoted lines

>
>> diff --git a/builtin/clean.c b/builtin/clean.c
>> index d861f836a..937eb17b6 100644
>> --- a/builtin/clean.c
>> +++ b/builtin/clean.c
>> @@ -857,6 +857,38 @@ static void interactive_main_loop(void)
>>         }
>>   }
>>   +static void correct_untracked_entries(struct dir_struct *dir)
>
> Looking what the function does, would
> drop_or_keep_untracked_entries()
> make more sense ?

To me, drop_or_keep_ implies that they're either all dropped or all kept, nothing in between, which is why I went with correct_, to indicate that the set of untracked entries in the dir_struct prior to calling the method needs to be corrected.