Re: [PATCH 2/5] difftool: Eliminate global variables
- From
David Aguilar <davvid@gmail.com>
- Date
- Jul 23, 2012, 06:44 UTC
- Message-ID
- <CAJDDKr77d0vot30txya7Z0QpOj2xgV4-0ZhOuyXiJbG2OSUNQQ@mail.gmail.com>
- In-Reply-To
- <CAHGBnuM9LgeLiOoFfny8NbF547okjQBLDXfzrbTj6vt+d=M4Eg@mail.gmail.com>
On Sun, Jul 22, 2012 at 11:30 PM, Sebastian Schuberth <sschuberth@gmail.com> wrote:
Show 14 quoted lines
> On Mon, Jul 23, 2012 at 8:21 AM, David Aguilar <davvid@gmail.com> wrote: > >>> Funny, I just have prepared a patch along the same lines so that one can >>> call git-difftool -h and --tool-help also outside a repository, see below. >>> Does you patch offer the same? If so, I'll drop mine. >> >> It *should*. I did not consider this case but that is indeed the >> desired behavior. >> >> What my patch did not offer was a test to ensure this behavior... > > Well, I'm not asking for a test. From my side, I'd be happy if you > could just try it and confirm that it works, as I currently cannot > easily apply your patch.
Heheh.. I was hoping you could provide a test ;-)
I just tried it now. They work outside of a repository.
-- David