git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/5] difftool: Simplify print_tool_help()

From
David Aguilar <davvid@gmail.com>
Date
Jul 25, 2012, 01:52 UTC
Message-ID
<CAJDDKr47F9ZAPPCnFBdPYhQsx8qGGggHHrFWeZw2zpf-mukq5w@mail.gmail.com>
In-Reply-To
<CAFouetjhGChULHa-Ax9oR--TccyEBnqn=UATbMpJxcdm3AOE1w@mail.gmail.com>
On Tue, Jul 24, 2012 at 5:43 AM, Tim Henigan <tim.henigan@gmail.com> wrote:
Show 15 quoted lines
> On Sun, Jul 22, 2012 at 11:42 PM, David Aguilar <davvid@gmail.com> wrote:
>> Eliminate a global variable and File::Find usage by building upon
>> basename() and glob() instead.
>
> glob was used in an early revision of the patch that led to bf73fc2
> (difftool: print list of valid tools with '--tool-help') as well [1].
> However, if the path to git or the path under 'mergetools' includes
> spaces, glob fails.  To work around the problem, File::Find was used
> instead [2].
>
> Does this implementation handle that case?  I'm sorry, but I haven't
> had time to apply and test myself.
>
> [1]: http://thread.gmane.org/gmane.comp.version-control.git/193233/focus=193925
> [2]: http://thread.gmane.org/gmane.comp.version-control.git/194158

Good catch. Eliminating the globals should be the goal, then. I'll have to re-roll.

-- 
David
Previous: Tim HeniganNext: David Aguilar
Message 12 of 15 in “difftool: Simplify print_tool_help()”
  1. 1/5 difftool: Simplify print_tool_help()David Aguilar, Jul 23, 2012
  2. 2/5 difftool: Eliminate global variablesDavid Aguilar, Jul 23, 2012
  3. Sebastian SchuberthJul 23, 2012
  4. David AguilarJul 23, 2012
  5. Sebastian SchuberthJul 23, 2012
  6. David AguilarJul 23, 2012
  7. Sebastian SchuberthJul 23, 2012
  8. 3/5 difftool: Move option values into a hashDavid Aguilar, Jul 23, 2012
  9. David AguilarJul 23, 2012
  10. 5/5 difftool: Use symlinks when diffing against the worktreeDavid Aguilar, Jul 23, 2012
  11. Tim HeniganJul 24, 2012
  12. David AguilarJul 25, 2012
  13. David AguilarJul 25, 2012
  14. Junio C HamanoJul 25, 2012
  15. David AguilarJul 25, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.