Re: [PATCH v5 1/2] config: let git_config_parse_key() validate quietly
- From
Harald Nordgren <haraldnordgren@gmail.com>
- Date
- Jun 2, 2026, 16:31 UTC
- Message-ID
- <CAHwyqnXC=F-ewFy3nejzKZcSNNe5L73PcaH+b30wg_BKNpStYA@mail.gmail.com>
- In-Reply-To
- <xmqqtsrlujah.fsf@gitster.g>
Show 5 quoted lines
> Perhaps the updated "git_config_parse_key()" in this patch should be > renamed to be a file-scape static internal helper, and the existing > "git_config_parse_key()" should become a thin wrapper around that > new helper function, retaining the current external interface, > requiring no changes to existing callers.
I want to remember a discussion on one of my earlier topics, a few months back, where someone else suggested instead of introducing two thin wrappers over a helper, we should update the callers instead.
But for me either way is fine, maybe here it makes more sense, because of the repeated NULL/0/1 parameters.
Harald