Re: [PATCH] config: suggest the correct form when key contains "="
- From
Harald Nordgren <haraldnordgren@gmail.com>
- Date
- May 16, 2026, 12:51 UTC
- Message-ID
- <CAHwyqnWC5z5ioxOFew-kV_8tA-eO_o7KvmM4XzNBu8VCtpx+uQ@mail.gmail.com>
- In-Reply-To
- <xmqqqzndel8c.fsf@gitster.g>
Show 13 quoted lines
> And I think git_config_parse_key() is at a way too low level to tell > in what context we are seeing this faulty key to guess end-user's > intention to limit our "did you mean?" > > I also wonder if, given that "=" in anywhere other than three-level > names, is invalid, we should just start accept > > git config foo.bar=baz > git config set foo.bar=baz > > and interpret them as > > git config set foo.bar baz
I tried implementing a version to be more liberal in what to accept, but the implementation became very complex.
Moving in the other direction: show the warning, but try to make it more correct.
(Also switching over to replying to emails with Gmail with 'plain text mode'), hopefully there will be less miss-sends that end up on the wrong topic from now on.)
Harald