Re: [PATCH v6 2/2] bisect: add --reset-when-found to leave when done
- From
Harald Nordgren <haraldnordgren@gmail.com>
- Date
- Aug 6, 2026, 15:59 UTC
- Message-ID
- <CAHwyqnX2wUsccqwmp-3WTsZQOcq0VV2TGHMPEpgKsGxOcH3sTQ@mail.gmail.com>
- In-Reply-To
- <xmqqik5nmk7s.fsf@gitster.g>
On Thu, Aug 6, 2026 at 3:50 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 15 quoted lines
> > Harald Nordgren <haraldnordgren@gmail.com> writes: > > >> Are there "dead end" states, other than '1st-bad-found', in which we > >> can no longer make any progress? One thing that comes to mind is > >> "you said this one is good, but that contradicts what you said about > >> its ancestor that you said is bad". I wonder if we want to do > >> anything special here, just as this part of the code handles the > >> '1st-bad-found' state, for such "dead end" states. > > > > Maybe, but I'm not sure this topic is the right place to dig into this? > > No. But thinking if it supports such new use cases in the future > before committing to the new code structure is something you would > want to make a habit of doing.
It makes sense, but it is still hard for me to reason about the system as a whole or how it will develop. I still have a myopic view of the codebase. But I agree in principle.
> I personally think the new "do your thing just as usual, but then > the new code cleans up afterwards" structure better supports > anything new we will throw at in the future.
I'll take this as not needing any change now. Overall, I am a big believer in the power of iterative development.
Harald